-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing .NET assemblies #1943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like there are a few CLI test failures (adding the snippet here since the log goes on for a while):
|
wagoodman
reviewed
Jul 17, 2023
wagoodman
reviewed
Jul 17, 2023
wagoodman
reviewed
Jul 17, 2023
wagoodman
reviewed
Jul 17, 2023
kaniini
reviewed
Jul 17, 2023
Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: 69c33fe
Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: b9d204e
Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: 9711c00
Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: 368313f
Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: e42fd77
Hmm I'm seeing CLI test failures on |
wagoodman
reviewed
Jul 19, 2023
Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: 95b25f8
Signed-off-by: Alex Goodman <[email protected]> Former-commit-id: fa54c0d0aef0998d5520e9f44cae51f5f9cd38a2
Signed-off-by: Dan Luhring <[email protected]>
wagoodman
approved these changes
Jul 19, 2023
This was referenced Jul 31, 2023
Closed
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* Add support for parsing .NET assemblies Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: 69c33fe * Add dll and exe files Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: b9d204e * Add PE cataloger to directory catalogers Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: 9711c00 * Don't set language to dotnet for PEs Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: 368313f * Fix spelling of cataloger in constructor Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: e42fd77 * Adjust which cases in PE parsing return errors Signed-off-by: Dan Luhring <[email protected]> Former-commit-id: 95b25f8 * remove build binary from branch Signed-off-by: Alex Goodman <[email protected]> Former-commit-id: fa54c0d0aef0998d5520e9f44cae51f5f9cd38a2 * Fix failing CLI tests Signed-off-by: Dan Luhring <[email protected]> --------- Signed-off-by: Dan Luhring <[email protected]> Co-authored-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, to learn about installed .NET software, Syft parses
*.deps.json
files it discovers on the filesystem. This approach is incorrect, and it leads to Syft surfacing incorrect data about what's installed, which also leads to false positives in Grype.This PR adds a new cataloger and parser to parse .NET assemblies themselves — which are Portable Executables — to find the correct name, version, and other metadata for the software installed on disk.
Fixes: #1799
Here's a new Syft scan of the image referenced in that bug report:
Here we see a version that we'd expect (7.0.*), given that we know .NET 7 is what's installed in this image.