feat(cmd/update): add UA header with current ver when check for update #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
add-user-agent-when-check-for-version-update
branch
from
966e004
to
2d1f75a
Compare
kzantow
reviewed
Sep 6, 2023
cmd/syft/cli/commands/update.go
Outdated
| req, err := http.NewRequest(http.MethodGet, latestAppVersionURL.host+latestAppVersionURL.path, nil) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to create request for latest version: %w", err) | ||
| } | ||
| req.Header.Add("User-Agent", fmt.Sprintf("%v %v", "Syft", currentVersion)) |
There was a problem hiding this comment.
I think we should instead modify this function to take the id clio.Identification as a parameter (and, by association the isUpdateAvailable function), then this line would be something like:
req.Header.Add("User-Agent", fmt.Sprintf("%v %v", id.Name, id.Version))
There was a problem hiding this comment.
Thanks for the prompt review! Sounds reasonable to me, I'll try pushing new commits to amend this
There was a problem hiding this comment.
Done pushing. PTAL again. Thanks!
Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
add-user-agent-when-check-for-version-update
branch
from
74a7ffd
to
535a8e7
Compare
kzantow
approved these changes
Sep 6, 2023
spiffcs
added a commit
to dlorenc/syft
that referenced
this pull request
Sep 7, 2023
* main: chore(deps): update bootstrap tools to latest versions (anchore#2086) chore(deps): update CPE dictionary index (anchore#2089) chore(deps): bump github.com/saferwall/pe from 1.4.4 to 1.4.5 (anchore#2096) chore(deps): bump github.com/docker/docker (anchore#2098) chore(deps): bump golang.org/x/net from 0.14.0 to 0.15.0 (anchore#2099) feat(cmd/update): add UA header with current ver when check for update (anchore#2100) fix(cdx): validate external refs before encoding (anchore#2091) expose cobra command in cli package (anchore#2097) Signed-off-by: Christopher Phillips <[email protected]>
This was referenced Sep 12, 2023
Closed
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
anchore#2100) Signed-off-by: hainenber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2072
PR description
When check for version update during
syftcommands, specify UA header with current version of the binary.Notes