fix: improve dotnet portable executable identification #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we expect this to be merged soon ? #2241 |
Signed-off-by: Keith Zantow <[email protected]>
kzantow
force-pushed
the
fix/dotnet-cataloger-field-lookup
branch
from
79ae4fb
to
78bde03
Compare
Signed-off-by: Keith Zantow <[email protected]>
|
Sorry for the delay @cichy3000 -- I didn't want to get a change like this merged without some due diligence looking at examples in the wild to make sure we're not regressing. As noted in the description there's a spreadsheet with a lot of examples that was used to determine the behavior implemented in this PR |
wagoodman
reviewed
Nov 29, 2023
wagoodman
approved these changes
Nov 29, 2023
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
spiffcs
added a commit
to coheigea/syft
that referenced
this pull request
Dec 5, 2023
* main: (40 commits) chore(deps): bump anchore/sbom-action from 0.15.0 to 0.15.1 (anchore#2392) Retrieve remote licenses using pom.properties when there is no pom.xml (anchore#2315) fix(java): improve identification for org.apache.tapestry artifacts (anchore#2384) fix(java): improve identification for io.ratpack artifacts (anchore#2379) fix(java): improve identification for org.apache.cassandra artifacts (anchore#2386) fix(java): improve identification for org.neo4j.procedure artifacts (anchore#2388) fix: bump fangs for ptr summarize fix (anchore#2387) fix(java): improve identification for org.elasticsearch artifacts (anchore#2383) fix(java): improve identification for org.apache.geode artifacts (anchore#2382) fix(java): improve identification for org.apache.tomcat.embed artifacts (anchore#2381) fix(java): improve identification for io.projectreactor.netty artifacts (anchore#2378) fix(java): improve identification for org.eclipse.platform artifacts (anchore#2349) Generalize UI events for cataloging tasks (anchore#2369) chore(deps): update tools to latest versions (anchore#2376) chore(deps): bump github.com/google/go-containerregistry (anchore#2377) chore: fix tests failing due to Mac Rosetta cache (anchore#2374) fix: improve dotnet portable executable identification (anchore#2133) fix file metadata cataloger to use resolved locations (anchore#2370) fix: logging level for parsing potential PE files (anchore#2367) only remove breaking-change label when there are schema changes (anchore#2371) ... Signed-off-by: Christopher Phillips <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Keith Zantow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve the dotnet portable executable identification.
Fixes: #2029
In order to try to determine reasonable behavior, I created a spreadsheet of all the PE Version Resources from:
The general pattern in this limited data set seems to be: Microsoft PE files used the
FileDescriptionwhile non-Microsoft vendors provided reasonable values in theProductName. Additionally, this PR attempts to improve version detection based on some examples found in the wild.