Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return builder object if $resetModel = false #738

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vrkansagara
Copy link

Returning the builder object give more power to integrate l5-repository with other library.

@vrkansagara vrkansagara changed the title Return builder if $resetModel = false Return builder object if $resetModel = false Oct 21, 2020
@vrkansagara
Copy link
Author

Ping @andersao This would need to review on urgent bases. On of my project suffering from this PR.

@bsormagec
Copy link
Collaborator

This is really user specific changes. Please use it by overwriting. If we need to do is need to implement it all classes. Thanks for pr @vrkansagara

@vrkansagara
Copy link
Author

vrkansagara commented Oct 30, 2020 via email

@bsormagec
Copy link
Collaborator

Create new BaseRepository.php file in App/Repositories/BaseRepository.php and extends it main BaseRepository.php and overwrite any function you want to change. @vrkansagara

@vrkansagara
Copy link
Author

This feature is useful without modification of abstraction and provide flexibility at run time. @bsormagec @andersao

@bsormagec
Copy link
Collaborator

If you want to made it useful you need to change it every class has resetMode not only one method.

@vrkansagara
Copy link
Author

agree @bsormagec , Let discuss here for other method as well. if other people agree upon this solutions I can add to other method as well. # #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants