PR: Add support for ConPTY and Python 3.9 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Apr 26, 2021
There was a problem hiding this comment.
Thanks a lot for this @andfoy! I left you some minor comments, otherwise looks pretty good.
Co-authored-by: Carlos Cordoba <[email protected]>
…rust_migration Merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the package from using Cython to compiling native code via Rust/CXX/PyO3, allowing to provide support for both WinPTY and the latest ConPTY. It also adds updated CIs
Fixes #136
Fixes #134
Fixes #133
Fixes #122
Fixes #121
Closes #131
Closes #133