Build and publish with Python 3.10 in GitHub actions. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Oct 11, 2021
There was a problem hiding this comment.
@joseph-roitman, thanks a lot for your help with this! I left a small comment for you, otherwise looks good to me.
joseph-roitman
force-pushed
the
build-python310
branch
from
55368bf
to
d350626
Compare
|
@joseph-roitman, thanks for the help with this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185
I test ran the GitHub actions on my fork and everything seems to work fine.
I also built pywinpty in a local Miniconda environment and successfully installed the built wheel in a clean Python 3.10 installation.