Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent iseof from returning immediately #47

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Prevent iseof from returning immediately #47

merged 1 commit into from
Jan 2, 2023

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jan 2, 2023

Since windows-rs now exposes the original C++ arguments, there was a minor confusion in which the total number of bytes remaining on the output stream handle was not being retrieved. Instead the function returned immediately since the total number of bytes to read was being set to a garbage value

@andfoy andfoy changed the title Prevent iseof from returning immediately PR: Prevent iseof from returning immediately Jan 2, 2023
@andfoy andfoy changed the title PR: Prevent iseof from returning immediately Prevent iseof from returning immediately Jan 2, 2023
@andfoy andfoy added this to the v0.3.11 milestone Jan 2, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #47 (e6dc3ae) into main (409fef9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   76.18%   76.18%           
=======================================
  Files           8        8           
  Lines        1243     1243           
=======================================
  Hits          947      947           
  Misses        296      296           
Flag Coverage Δ
unittests 76.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pty/base.rs 70.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andfoy andfoy merged commit dc9565f into main Jan 2, 2023
@andfoy andfoy deleted the fix_eof_error branch January 2, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants