Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reading thread from hanging if process has stopped #79

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Oct 11, 2024

Fixes #72

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (1963287) to head (c36c7cd).

Files with missing lines Patch % Lines
src/pty/base.rs 75.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   78.79%   78.66%   -0.13%     
==========================================
  Files           7        7              
  Lines        1240     1308      +68     
==========================================
+ Hits          977     1029      +52     
- Misses        263      279      +16     
Flag Coverage Δ
unittests 78.66% <94.20%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andfoy andfoy changed the title Cancel all pending I/O operations when checking for EOF Prevent reading thread from hanging if process has stopped Oct 11, 2024
@andfoy andfoy merged commit 1772d00 into main Oct 17, 2024
3 of 4 checks passed
@andfoy andfoy deleted the prevent_race_condition_eof branch October 17, 2024 15:21
@andfoy andfoy added this to the v0.4.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE REQUEST: Callback or blocking method to wait for exit of spawned process
2 participants