Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Collage - retake a single picture #166

Closed
lasolco opened this issue Jan 3, 2021 · 6 comments · Fixed by #200
Closed

Collage - retake a single picture #166

lasolco opened this issue Jan 3, 2021 · 6 comments · Fixed by #200
Assignees
Labels

Comments

@lasolco
Copy link

lasolco commented Jan 3, 2021

Hi, I noticed during a collage a nice new feature.

For example, you do 4 pictures during the collage, but during the 2nd picture a mistake took place. So it would be great to have the possibility to retake the picture or to request the user to accept a picture for the collage.

I would like to suggest to add the possibility to request the user after each picture of the collage to acknowledge the picture or do a retake.

Thank you very much!

Best regards

@lasolco lasolco added the enhancement New feature or request label Jan 3, 2021
@andi34
Copy link
Owner

andi34 commented Jan 3, 2021

Hey @lasolco !
Thanks for your suggestion. I am about to rework some code of the collage creation and will take a look on your idea once I've more time (there's some other stuff on my to-do-list too which I need to finish first).

For future feature request(s) please use the feature request template.

Best regards

Andi

@andi34 andi34 self-assigned this Feb 7, 2021
@andi34 andi34 added the WIP Work in progress label Feb 7, 2021
@andi34
Copy link
Owner

andi34 commented Feb 7, 2021

Started working on it.

ezgif-4-93153365c4ae

Todo:

  • don't repeate picture
  • delete old picture to take a new one

@andi34 andi34 added resolved and removed WIP Work in progress labels Feb 7, 2021
@andi34
Copy link
Owner

andi34 commented Feb 7, 2021

Will be included in next release

@andi34 andi34 closed this as completed Feb 7, 2021
@jacques42
Copy link
Collaborator

Did you get to test if this also works with an active RemoteBuzzer integration ? Let me know in case not and I'll have a look

@andi34
Copy link
Owner

andi34 commented Feb 7, 2021

No, would be great if you're able to test. But I have to push one fix later.

@andi34
Copy link
Owner

andi34 commented Feb 7, 2021

ezgif-4-cb1f11611c61

andi34 added a commit that referenced this issue Mar 1, 2021
Fix #166

Change-Id: I50a950051516c152c80edc7b898883a9d9a793c2
andi34 added a commit that referenced this issue Mar 1, 2021
Fix #166

Change-Id: I50a950051516c152c80edc7b898883a9d9a793c2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants