Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Print optimizations and new auto print feature #109

Merged
merged 7 commits into from
Sep 18, 2020
Merged

Conversation

andi34
Copy link
Owner

@andi34 andi34 commented Sep 14, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

  • New feature
  • Other, please explain: see below

What changes did you make? (Give an overview)

Auto print function
inspired by implementation from alzo425: alzo425@90099f1

  • Slight adjustments for latest Photobooth, removed unneeded code changes

New options

  • allow to delay auto print
  • allow to adjust time "Started printing! Please wait..." is visible
  • allow to trigger print via defined key
  • check if we're already printing to avoid double printing
  • options to show the print button independent

Is there anything you'd like reviewers to focus on?

Inspired by implementation from alzo425: alzo425@90099f1

- Slight adjustments for latest Photobooth, removed unneeded code changes.

Change-Id: I24a192dbab03952f9310c2d8f8efe6f2538d7135
@lagrandeours
Copy link

it s very good option if it s possible to add a delay of 3/5 seconds to let people take picture again if the picture is not good

@andi34
Copy link
Owner Author

andi34 commented Sep 15, 2020

In that case better don't enable the option and use the print button.

Change-Id: Iba09c5dfba27d7c8dd9ef0bab55ab39e8a3f174c
Change-Id: I35cb076859bb2a70e893e0a2b1891f4df9bbe1db
Change-Id: I2aed70538041ec5d7aa2d22d972e03804edf74bd
@andi34 andi34 changed the title feature (auto print): allow to print picture directly after taken Print optimizations and new auto print feature Sep 15, 2020
@andi34
Copy link
Owner Author

andi34 commented Sep 16, 2020

Need to add missing strings, will force push in the evening.

Change-Id: Icb40c3a21b3e304ccbf487b387d686edaa9fcc32
Change-Id: Iceedd49b20f87c9f48a0930155923f3ec5bf09ff
Change-Id: I63cdcd71f95e0f4d3405c0e55b5b0c00a74c4827
@andi34 andi34 merged commit 97dddc3 into dev Sep 18, 2020
@andi34
Copy link
Owner Author

andi34 commented Sep 18, 2020

On my To-Do-List as further improvements

  • print-counter
  • allow printing 2 pictures or more

@andi34 andi34 deleted the feature/autoprint branch September 18, 2020 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants