This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
Feature: shutter animation #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andi34
commented
Jan 16, 2022
up-87
reviewed
Jan 16, 2022
up-87
reviewed
Jan 16, 2022
andi34
force-pushed
the
feature/shutter-animation
branch
2 times, most recently
from
77e672b
to
9d67871
Compare
Currently just two layers displayed over everything - not really optimal. Doesn't work on all pictures of a collage yet. Change-Id: I756a2d46cf779d0af78b19c7c90473ebc391070a
- reset aperture and blocker css values to default Change-Id: I32f065c7d03bb28c86478f1915c9d08859008010
Change-Id: I77c3cd93ed1136ba6dc004083889b64d6bd301f0
Move the shutter start and stop animation to it's own function, this way we are more flexible while adjusting things if needed. Change-Id: If4b9c8c4d3f664bb44c40b5a19124b86bac52305
Change-Id: I5750bfd63f533f24a755cef2788e2ac926534595
andi34
force-pushed
the
feature/shutter-animation
branch
from
9d67871
to
968b2e8
Compare
|
@up-87 anything left? IMO can be rebased and merged if there's currently no further improvement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
Add a simple shutter animation while taking a picture. Implementation from @up-87,
fixed animation on retry / next collage image.
Made shutter animation an option inside Adminpanel, animation is enabled by default.
Is there anything you'd like reviewers to focus on?