Simplify is any #107
Merged
Simplify is any #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @krisdages for pointing out this simplification! This PR makes the `IsAny` type much more simple. Previously we were exhaustively checking that the given type, `T`, was _not_ any other type. This is pretty prone to mistake and is not very sustainable (a new fundamental type could be introduced).
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @krisdages for pointing out this simplification! This PR makes
the
IsAnytype much more simple. Previously we were exhaustivelychecking that the given type,
T, was not any other type. This ispretty prone to mistake and is not very sustainable (a new fundamental
type could be introduced).
Closes #105