Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compile issues on Node 4 #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martinheidegger
Copy link

I ran into compile errors when trying to install kissfft on Node 4.0

../src/bindings.cpp:20:23: error: unknown class name 'NanAsyncWorker'; did you mean 'Nan::AsyncWorker'?
class Worker : public NanAsyncWorker {
                      ^~~~~~~~~~~~~~
                      Nan::AsyncWorker
../node_modules/nan/nan.h:1452:22: note: 'Nan::AsyncWorker' declared here
/* abstract */ class AsyncWorker {
                     ^
../src/bindings.cpp:25:10: error: unknown type name 'NanCallback'
  Worker(NanCallback* callback, Local<Object> input, Local<Object> output);
         ^
../src/bindings.cpp:60:45: error: unknown type name 'NanCallback'
Worker<cfg_type, in_type, out_type>::Worker(NanCallback *callback, Local<Object> input, Local<Object> output)
                                            ^
../src/bindings.cpp:62:21: error: no member named 'GetIndexedPropertiesExternalArrayDataLength' in 'v8::Object'
  int nfft = input->GetIndexedPropertiesExternalArrayDataLength();
             ~~~~~  ^
../src/bindings.cpp:63:23: error: no member named 'GetIndexedPropertiesExternalArrayDataLength' in 'v8::Object'
  if (nfft == output->GetIndexedPropertiesExternalArrayDataLength())
              ~~~~~~  ^
../src/bindings.cpp:68:32: error: no member named 'GetIndexedPropertiesExternalArrayData' in 'v8::Object'
  in = (const in_type*) input->GetIndexedPropertiesExternalArrayData();
                        ~~~~~  ^
../src/bindings.cpp:69:29: error: no member named 'GetIndexedPropertiesExternalArrayData' in 'v8::Object'
  out = (out_type*) output->GetIndexedPropertiesExternalArrayData();
                    ~~~~~~  ^
../src/bindings.cpp:79:3: error: use of undeclared identifier 'NanScope'
  NanScope();
  ^
../src/bindings.cpp:82:29: error: use of undeclared identifier 'NanNull'
  Handle<Value> argv[2] = { NanNull(), output };
                            ^
../src/bindings.cpp:92:3: error: use of undeclared identifier 'NanScope'
  NanScope();
  ^
../src/bindings.cpp:94:33: error: use 'template' keyword to treat 'As' as a dependent template name
  Local<Object> input = args[0].As<Object>();
                                ^
                                template
../src/bindings.cpp:94:25: error: use of undeclared identifier 'args'
  Local<Object> input = args[0].As<Object>();
                        ^
../src/bindings.cpp:95:34: error: use 'template' keyword to treat 'As' as a dependent template name
  Local<Object> output = args[1].As<Object>();
                                 ^
                                 template
../src/bindings.cpp:95:26: error: use of undeclared identifier 'args'
  Local<Object> output = args[1].As<Object>();
                         ^
../src/bindings.cpp:96:38: error: use 'template' keyword to treat 'As' as a dependent template name
  Local<Function> callback = args[2].As<Function>();
                                     ^
                                     template
../src/bindings.cpp:96:30: error: use of undeclared identifier 'args'
  Local<Function> callback = args[2].As<Function>();
                             ^
../src/bindings.cpp:98:3: error: unknown type name 'NanCallback'
  NanCallback* nanCallback = new NanCallback(callback);
  ^
../src/bindings.cpp:98:34: error: unknown type name 'NanCallback'
  NanCallback* nanCallback = new NanCallback(callback);
                                 ^
../src/bindings.cpp:101:61: error: use of undeclared identifier 'kExternalFloatArray'
      input->GetIndexedPropertiesExternalArrayDataType() != kExternalFloatArray ||
                                                            ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [Release/obj.target/kissfft/src/bindings.o] Error 1

this should perhaps fix them?

@martinheidegger
Copy link
Author

Seems like something is broken?

@dy dy mentioned this pull request May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant