Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 0,0 as default origin #319

Closed
wants to merge 1 commit into from
Closed

Use 0,0 as default origin #319

wants to merge 1 commit into from

Conversation

chuckwagoncomputing
Copy link
Contributor

@chuckwagoncomputing chuckwagoncomputing commented Aug 2, 2023 •
edited by rusefillc
Loading

@rusefillc
Copy link
Collaborator

@andreika-git please review

@andreika-git
Copy link
Owner

I'd prefer fail with an explicit error if aux_axis_origin is not set, because in this case the origin in kicad is usually random, not zero, and we'll get mismatched origins for vrml and rest of the board.

@rusefillc
Copy link
Collaborator

@chuckwagoncomputing I took half of your lines and made it into 7678483

@rusefillc rusefillc closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chuckwagoncomputing @rusefillc @andreika-git