Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to choose between NSYS and NCU profilers #28

Merged
merged 32 commits into from
Mar 20, 2024

Conversation

cosminc98
Copy link
Collaborator

  • Add option to choose between NSYS and NCU profilers
  • Fix isort and black issues
  • Can search for profiling tool paths recursively in directories where they are expected to exist (if they do not exist in PATH)
  • Documented changes

… allow reusing them in multiple magic command calls
…able-unstable-feature as it was removed in version 24.1.0
@cosminc98 cosminc98 closed this Feb 16, 2024
@cosminc98 cosminc98 reopened this Feb 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (781ff5b) 94.19% compared to head (3f8b89c) 92.57%.

Files Patch % Lines
nvcc4jupyter/path_utils.py 87.50% 1 Missing and 2 partials ⚠️
nvcc4jupyter/plugin.py 90.00% 1 Missing and 1 partial ⚠️
nvcc4jupyter/parsers.py 91.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   94.19%   92.57%   -1.62%     
==========================================
  Files           3        4       +1     
  Lines         155      202      +47     
  Branches       21       32      +11     
==========================================
+ Hits          146      187      +41     
- Misses          5        8       +3     
- Partials        4        7       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosminc98
Copy link
Collaborator Author

@andreinechaev After reviewing the changes, please push the v1.2.0 tag (same reasoning: added features in a backward compatible manner so we bump the minor version).

@andreinechaev andreinechaev merged commit 0bddf6a into master Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants