Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RsyncTask - releasesDirectory checking issue #210

Closed
tychode opened this issue Mar 16, 2015 · 1 comment
Closed

RsyncTask - releasesDirectory checking issue #210

tychode opened this issue Mar 16, 2015 · 1 comment
Labels
Bug v1

Comments

@tychode
Copy link

tychode commented Mar 16, 2015

Hi,

In file Mage\Task\BuiltIn\Deployment\Strategy\RsyncTask.php the statement can be seen:

if ($rsync_copy && is_array($rsync_copy) && $rsync_copy['copy'] && is_dir("$releasesDirectory/$currentRelease"))

This statement is always false. The function is_dir() checks whether path‘s $releasesDirectory/$currentRelease exist locally.
@tychode tychode changed the title RsyncTask - if statement problem RsyncTask - releaseDirectory checking issue Mar 16, 2015
@tychode tychode changed the title RsyncTask - releaseDirectory checking issue RsyncTask - releasesDirectory checking issue Mar 16, 2015
andres-montanez added a commit that referenced this issue Apr 12, 2015
@andres-montanez
Issue #210
139b897
@andres-montanez
Copy link
Owner

Hi! Good point!
The new release takes care of this.

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug v1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andres-montanez @tychode