Fix 1st deploy bug #195
Merged
Fix 1st deploy bug #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoa, the code here is so complecated that it's almost unreadable. Surely the feedback is needed here but for me this should work. |
|
Hey guys. Sorry but I didn't know how serious bug it is until today. Merging immediately! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 2 problems leading to a 1st deploy failure (one only with rsync strategy and the other more widely I think)
In
ReleaseTask.php, we're trying to change owner of symlink file. But on first release the symlink does not exists yet so the release fail (problem comes from #178 I think). I've updated to only check owner if symlink exists. (maybe we can remove totaly the symlink owner check as it's created after ?)In
RsyncTask.php, withrsync_copyenabled, if the previous release folder does not exists, the release directory is not created, and rsync fail. I've updated to revert to manual empty directory creation if there is no previous release.