Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add look up messages map #188

Closed

Conversation

knatnaela
Copy link

No description provided.

Natnael Adane added 30 commits August 11, 2022 17:03
@andresaraujo
Copy link
Owner

andresaraujo commented Aug 12, 2022

@knatnaela

Sorry I don't want to add all the locales in the map by default, the reason is that it will will increase the size of all the apps that load this library because they will include all these locales even if they don't use it. ( maps cannot be tree-shaken by the Dart compiler)

I might event remove spanish in the default map in the next major version, so users only load the locales they need.

EDIT:
Btw am messages are already included ready to import

@knatnaela
Copy link
Author

knatnaela commented Aug 13, 2022

ohh I see okay thanks.

@knatnaela knatnaela closed this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants