Feature/multitarget #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2023 12:59
Removing installation scripts as they are not working anyway (IMO) Since nuget v3 install.ps1 and uninstall.ps1 are not executed https://devblogs.microsoft.com/nuget/NuGet-3-What-and-Why/#powershell-install-and-uninstall-scripts The bug in current proj config was packing install/uninstall files inside /tools/tools/ folder instead of /tools/ which might have rendered them useless
…hen IDE supports that.
|
Sorry @murlakatam it has been a busy couple of weeks for me! I'll try and look at this tomorrow. |
andrewabest
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Alright I've had a look at this now, and have done some reading. Thanks for the detailed issue submission! Targeting net6/7 sounds like a good starting point, I will add dotnet 8 shortly too. CI build has passed and I double checked the package contents to ensure the multi-targeted outputs were present, which they were.
Thanks for cleaning up the install scripts too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85