Adds various new conventions #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flakey-bit
force-pushed
the
feature/GH-87-new-conventions
branch
from
62e51a9
to
34559b1
Compare
flakey-bit
commented
Jan 6, 2024
flakey-bit
commented
Jan 6, 2024
src/Core/TestSolution/TestSolution.TestProject/SdkClassLibrary1/SdkClassLibrary1.csproj
Show resolved
Hide resolved
flakey-bit
commented
Jan 6, 2024
| @@ -515,5 +515,63 @@ public void LibraryCodeShouldCallConfigureAwaitWhenAwaitingTasks_FailsWhenConfig | |||
| result.IsSatisfied.Should().BeFalse(); | |||
| result.Failures.Single().Should().Be(expectedFailureMessage); | |||
| } | |||
|
|
|||
| # region MustNotUseGuidNewGuid | |||
There was a problem hiding this comment.
remark: I've introduced a region here to make it obvious that all of this is associated with the MustNotUseGuidNewGuid convention.
Might be worth splitting this file up.
There was a problem hiding this comment.
I'm not too worried about splitting these test files up, they tend to be easy enough to peruse. Can we remove the #region though? It conflicts with my core beliefs 😆
added 6 commits
January 5, 2024 19:20
…ode doesn't directly call Guid.NewGuid() A possible use-case is code written in a functional style (that wants to avoid non-deterministic behaviour)
…included (by name) in a haystack set of assemblies This can be used to ensure a list of assemblies (e.g. those containing "production code") is kept up-to-date *so that you can apply conventions to the types in those assemblies*.
…ct doesn't include project references to (any) other projects
…ferences/does not reference a package (by name) An example use-case is something like the coverlet collector (https://github.com/coverlet-coverage/coverlet) which should be added ONLY to (ALL) test projects - Added new SDK-style project & bumped project count
…property
Some examples:
- Convention.MustSetPropertyValue("Nullable", "enable") // Ensure nullable types are enabled for the project
- Convention.MustSetPropertyValue("IsPackable", "true") // Ensure the project can be packed for NuGet
See https://learn.microsoft.com/en-us/visualstudio/msbuild/property-element-msbuild?view=vs-2022#example
…a given compiler warning as an error
flakey-bit
force-pushed
the
feature/GH-87-new-conventions
branch
from
34559b1
to
f5a4b38
Compare
Closed
andrewabest
approved these changes
Jan 7, 2024
|
Fixes #87 |
|
Ah... just forgot about that sneaky region before hitting merge! I'll remove it @flakey-bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds various new conventions (discussed in more detail in #87)
Things to note:
NamespaceMustStartWithbecause it turns out something equivalent already existed (not sure how I missed it)