Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-87] Adds Convention.NamespaceMustStartWith & Convention.Namespace.MustEndWith #93

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

flakey-bit
Copy link
Contributor

@flakey-bit flakey-bit commented Feb 17, 2024

These were discussed (see GH-87) but not implemented under pull-request GH-90 because I thought they already existed 🤦‍♂️

Currently (as of 11.0.11) there's only

  • Convention.NameMustStartWith / Convention.NameMustEndWith (which only consider the immediate type name, not FullName) and
  • Convention.MustLiveInNamespace (which doesn't support a prefix/suffix/regex)

…n.NamespaceMustEndWith (which were discussed but not implemented under pull-request andrewabestGH-90)

Currently (as of 11.0.11) there's only
- Convention.NameMustStartWith / Convention.NameMustEndWith (which only consider the immediate type name, not FullName) and
- Convention.MustLiveInNamespace (which doesn't support a prefix/suffix/regex)
Copy link
Owner

@andrewabest andrewabest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continued contributions @flakey-bit!

@andrewabest andrewabest merged commit 7d2d4ca into andrewabest:master Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants