Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetcaster]: Podcast screen #1296

Merged
merged 12 commits into from
Apr 1, 2024

Conversation

arriolac
Copy link
Contributor

@arriolac arriolac commented Mar 26, 2024

Changes:

  • Added podcast details screen.
  • Added external models PodcastInfo, EpisodeInfo and CategoryInfo so that composables don't depend on database entities (Podcast, Episode and `Category) directly.

Note that design is not final yet but will address that in another PR.

image

@arriolac arriolac changed the title WIP [Jetcaster]: Podcast screen [Jetcaster]: Podcast screen Mar 28, 2024
@arriolac arriolac marked this pull request as ready for review March 28, 2024 17:31
@arriolac arriolac requested a review from a team as a code owner March 28, 2024 17:31
@arriolac arriolac force-pushed the chris/jetcaster/podcast_screen branch from 9767457 to 3649e93 Compare March 29, 2024 13:32
Copy link
Contributor

@IanGClifton IanGClifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that there are models for the UI, I'd update PreviewData to use those directly. For example, it's a little weird to have

val PreviewEpisodeToPodcasts = listOf(
    EpisodeToPodcast().apply {
        episode = PreviewEpisodes.first()
        _podcasts = PreviewPodcasts
    }
)

and then in the preview itself, it uses asPodcastCategoryEpisode to convert everything. I think PreviewData shouldn't need com.example.jetcaster.core.data.database.* imports anymore.

@arriolac
Copy link
Contributor Author

Now that there are models for the UI, I'd update PreviewData to use those directly. For example, it's a little weird to have

val PreviewEpisodeToPodcasts = listOf(
    EpisodeToPodcast().apply {
        episode = PreviewEpisodes.first()
        _podcasts = PreviewPodcasts
    }
)

and then in the preview itself, it uses asPodcastCategoryEpisode to convert everything. I think PreviewData shouldn't need com.example.jetcaster.core.data.database.* imports anymore.

Done in 1c94c88

@arriolac
Copy link
Contributor Author

arriolac commented Apr 1, 2024

Going to merge this in @IanGClifton - if you have any other comments I'll address it in a separate PR. Thanks for your review 🙏

@arriolac arriolac force-pushed the chris/jetcaster/podcast_screen branch from f3ee677 to 40a6b47 Compare April 1, 2024 17:49
@arriolac arriolac merged commit 6058f86 into jetcaster/all_form_factors Apr 1, 2024
1 check passed
@arriolac arriolac deleted the chris/jetcaster/podcast_screen branch April 1, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants