-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetcaster]: Podcast screen #1296
[Jetcaster]: Podcast screen #1296
Conversation
9767457
to
3649e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that there are models for the UI, I'd update PreviewData to use those directly. For example, it's a little weird to have
val PreviewEpisodeToPodcasts = listOf(
EpisodeToPodcast().apply {
episode = PreviewEpisodes.first()
_podcasts = PreviewPodcasts
}
)
and then in the preview itself, it uses asPodcastCategoryEpisode to convert everything. I think PreviewData shouldn't need com.example.jetcaster.core.data.database.* imports anymore.
Jetcaster/app/src/main/java/com/example/jetcaster/ui/podcast/PodcastDetailsScreen.kt
Outdated
Show resolved
Hide resolved
Jetcaster/app/src/main/java/com/example/jetcaster/ui/podcast/PodcastDetailsScreen.kt
Outdated
Show resolved
Hide resolved
Done in 1c94c88 |
Going to merge this in @IanGClifton - if you have any other comments I'll address it in a separate PR. Thanks for your review 🙏 |
f3ee677
to
40a6b47
Compare
Changes:
PodcastInfo
,EpisodeInfo
andCategoryInfo
so that composables don't depend on database entities (Podcast
,Episode
and `Category) directly.Note that design is not final yet but will address that in another PR.