Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added predictive back support to the drawer #1454

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Conversation

IanGClifton
Copy link
Contributor

In M3 1.3, the drawerState can be passed to the ModalDrawerSheet to get predictive back animations without the need for a PredictiveBackHandler to be manually defined.

In M3 1.3, the drawerState can be passed to the ModalDrawerSheet to get
predictive back animations without the need for a PredictiveBackHandler
to be manually defined.
@IanGClifton
Copy link
Contributor Author

I've created this as a draft to validate it. Once there is a BOM that uses M3 1.3.0 stable, we can update all samples to that and I can push a new commit to this PR to remove the custom M3 version being set for this sample.

@IanGClifton IanGClifton marked this pull request as ready for review September 6, 2024 00:45
@IanGClifton IanGClifton requested a review from a team as a code owner September 6, 2024 00:45
@IanGClifton IanGClifton requested review from dturner and JolandaVerhoef and removed request for dturner September 6, 2024 00:45
Copy link
Collaborator

@riggaroo riggaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm, just the toml changes.

JetNews/gradle/libs.versions.toml Outdated Show resolved Hide resolved
@IanGClifton IanGClifton merged commit 4e2918a into main Sep 21, 2024
5 checks passed
@IanGClifton IanGClifton deleted the igc/jetnews-pb branch September 21, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants