Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reply] Add type safe navigation #1459

Merged
merged 5 commits into from
Sep 26, 2024
Merged

[Reply] Add type safe navigation #1459

merged 5 commits into from
Sep 26, 2024

Conversation

dturner
Copy link
Contributor

@dturner dturner commented Sep 6, 2024 •
edited
Loading

Adding type safe navigation to Reply app now that the stable API has been released.

I also had to add

kotlinOptions {
    jvmTarget = "17"
}

to avoid getting the following build error:

Inconsistent JVM-target compatibility detected for tasks 'compileDebugJavaWithJavac' (17) and 'compileDebugKotlin' (21).

@dturner dturner requested a review from a team as a code owner September 6, 2024 22:23
@dturner dturner self-assigned this Sep 6, 2024
@dturner dturner marked this pull request as draft September 6, 2024 22:26
riggaroo
riggaroo approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@riggaroo riggaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Reply/app/src/main/java/com/example/reply/ui/navigation/ReplyNavigationActions.kt Outdated Show resolved Hide resolved
@dturner dturner changed the title Add type safe navigation [Reply] Add type safe navigation Sep 26, 2024
@dturner dturner marked this pull request as ready for review September 26, 2024 13:49
@dturner dturner merged commit 5b9a06f into main Sep 26, 2024
5 checks passed
@dturner dturner deleted the dt/type-safe-nav branch September 26, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riggaroo riggaroo riggaroo approved these changes

@MagicalMeghan MagicalMeghan Awaiting requested review from MagicalMeghan MagicalMeghan is a code owner automatically assigned from android/compose-devrel

Assignees

@dturner dturner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dturner @riggaroo