Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] [Graphics] - Implementation of "Displaying UltraHDR (Fresco) & (Coil)" #86

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

madebymozart
Copy link
Contributor

@madebymozart madebymozart commented Aug 22, 2023

Description

This CL contains sample code for Displaying UltraHDR using the Fresco Image Library & Coil Image Library.

Fresco - Using the ImagePipeline
Coil - Using Coroutines & ImageLoader

How Has This Been Tested?

Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta)

Demo

Screenshot_20230919_171902

@madebymozart madebymozart added the new sample This denotes the creation of a new sample in the platform samples app label Aug 22, 2023
@madebymozart madebymozart self-assigned this Aug 22, 2023
@madebymozart madebymozart changed the title [Sample] [Graphic] - Implementation of "Displaying UltraHDR (Fresco) & (Coil)" [Sample] [Graphics] - Implementation of "Displaying UltraHDR (Fresco) & (Coil)" Aug 22, 2023
Copy link
Contributor

@yrezgui yrezgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the existing Glide fragment? With a button, you can switch between libraries. It will reduce maintenance burden

@madebymozart
Copy link
Contributor Author

This makes sense, will do so!

@@ -1,5 +1,7 @@
# Available Samples

- [](user-interface/predictiveback/src/main/java/com/example/platform/ui/predictiveback/PBHostingActivity.kt):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line as it's not part of this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

samples/README.md Outdated Show resolved Hide resolved
documentation = "https://github.com/bumptech/glide",
tags = ["UltraHDR"],
)
@RequiresApi(VERSION_CODES.UPSIDE_DOWN_CAKE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Ultra HDR support backported through libraries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not, UltraHDR the format is backwards compatible, but high brightness mode is new to API 34

@yrezgui yrezgui removed the request for review from marcelpinto October 17, 2023 02:01
@yrezgui yrezgui merged commit 4cd7c58 into main Oct 17, 2023
4 checks passed
@madebymozart madebymozart deleted the ultrahdr-using-fresco-and-coil branch October 17, 2023 02:08
yrezgui added a commit that referenced this pull request Dec 7, 2023
… & (Coil)" (#86)

* Create Fresco & Coil Samples For displaying UltraHDR

* Update to code to combine into 1 sample

* Update samples/README.md

---------

Co-authored-by: Yacine Rezgui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new sample This denotes the creation of a new sample in the platform samples app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants