-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sample] [Graphics] - Implementation of "Displaying UltraHDR (Fresco) & (Coil)" #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use the existing Glide fragment? With a button, you can switch between libraries. It will reduce maintenance burden
This makes sense, will do so! |
samples/README.md
Outdated
@@ -1,5 +1,7 @@ | |||
# Available Samples | |||
|
|||
- [](user-interface/predictiveback/src/main/java/com/example/platform/ui/predictiveback/PBHostingActivity.kt): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line as it's not part of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
documentation = "https://github.com/bumptech/glide", | ||
tags = ["UltraHDR"], | ||
) | ||
@RequiresApi(VERSION_CODES.UPSIDE_DOWN_CAKE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't Ultra HDR support backported through libraries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not, UltraHDR the format is backwards compatible, but high brightness mode is new to API 34
36e5b5b
to
9f2dab5
Compare
… & (Coil)" (#86) * Create Fresco & Coil Samples For displaying UltraHDR * Update to code to combine into 1 sample * Update samples/README.md --------- Co-authored-by: Yacine Rezgui <[email protected]>
Description
This CL contains sample code for Displaying UltraHDR using the Fresco Image Library & Coil Image Library.
Fresco - Using the
ImagePipeline
Coil - Using Coroutines &
ImageLoader
How Has This Been Tested?
Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta)
Demo