Show preview of VideoEditScreen #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to initialization of viewmodel in screen composable
l2hyunwoo
commented
Feb 15, 2024
| ) { | ||
| val context = LocalContext.current | ||
|
|
||
| val viewModel: VideoEditScreenViewModel = hiltViewModel() | ||
| viewModel.setChatId(chatId) |
There was a problem hiding this comment.
I think this logic can replace with ViewModel's SavedStateHandle.get
l2hyunwoo
commented
Feb 15, 2024
Comment on lines
+102
to
+104
| if (isFinishedEditing) { | ||
| navController.popBackStack("chat/$chatId", false) | ||
| } |
There was a problem hiding this comment.
Also I this logic should be considered as side-effect caused by isFinishedEditing, so I think it should be isolated by LaunchedEffect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Current preview of VideoEditScreen can't be rendered due to initialization of viewmodel in screen composable function.
Solution
I separate initialization logic to screen wrapper composable's input parameter. As I moved the ViewModel towards the input parameter of the Wrapper composable, I found that the state within the existing function also needed to be moved towards the wrapper.
Changed