-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As i'm not an expert, some comments
Thanks to @franzeszpere, @javichaques and @alorma for your contribution helping this project to improve Catalan translations PR. I applied all of your suggestions :), please check if all are ok now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several issues, I added suggestions for everything I think could be improved. The most common issue is that in Catalan, actions in buttons or menus must always be in imperative tense, not in infinitive (other languages like Spanish use infinitives instead, so this is a common error). For example, "Afegir" should be "Afegeix".
Oh, and thanks for translating it into Catalan! :P
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
@googlebot I fixed it. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@Ereza Thank you numerous contribution to improve Catalan translation for this sample project, I merge several of them having pending only two suggest changes to discuss more in detail. |
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
Co-Authored-By: Eduard Ereza Martínez <[email protected]>
@Ereza Thanks again for your contribution and time reviewing the translations 👏 . I update the PR with all the suggestions. Please review them and let's approve it for merge. Thank you all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for your time! :)
Thank you everyone for contributing to this translation! Added this to the list of translations on the Wiki. |
Description
Add support for the Catalan language as it was requested in #462