-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile error with The following Android dependencies are set to compileOnly which is not supported com.google.j2objc:j2objc-annotations:2.8 #1700
Comments
this is similar to #1325 and excluding guava works somehow. not sure why?
|
Thanks for your report. Can you please provide us with reproduction steps that would allow us to understand what you are exactly doing. I think adding the dependencies below alone shouldn't cause an issue.
However, I don't understand the details to be honest :). According to this comment the issue should be resolved with the latest version. (adding @tonihei who knows the details of how we resolved this internally) |
I am encountering this issue in my project that seems to be caused by the Guava library. The issue is resolved when I revert to version 1.2.1 of Media3 or as suggested by @ShivamGoyal1899 api(libs.androidx.media3.exoplayer) { However, I have another project using the same dependencies, without experiencing any issues. The key difference between the two projects is that on which issue occurs it uses a feature-delivery asset feature. What could be the reason for this inconsistency between projects? Could there be other conflicting dependencies or project-specific settings affecting this? |
Someone reported this to us on the Guava side in google/guava#7397. I'm working to fix it there. Once I do so, AndroidX should be able to upgrade to a new version of Guava, and the problem should go away. Sorry for the trouble. |
While that artifact contains no runtime-retention annotations, it does contain class-retention annotations (which could drive a runtime bytecode-rewriting agent). And, more practically, the Android Gradle Plugin has started reporting errors for `compileOnly` dependencies. Addresses #7397. (But I'll keep that issue open until I publish a release.) Relevant to firebase/firebase-android-sdk#6232 and androidx/media#1700. RELNOTES=Added `j2objc-annotations` to the Gradle runtime classpath to avoid [an Android Gradle Plugin error](#7397). PiperOrigin-RevId: 677781422
While that artifact contains no runtime-retention annotations, it does contain class-retention annotations (which could drive a runtime bytecode-rewriting agent). And, more practically, the Android Gradle Plugin has started reporting errors for `compileOnly` dependencies. Fixes #7397 Relevant to firebase/firebase-android-sdk#6232 and androidx/media#1700 RELNOTES=Added `j2objc-annotations` to the Gradle runtime classpath to avoid [an Android Gradle Plugin error](#7397). PiperOrigin-RevId: 677781422
While that artifact contains no runtime-retention annotations, it does contain class-retention annotations (which could drive a runtime bytecode-rewriting agent). And, more practically, the Android Gradle Plugin has started reporting errors for `compileOnly` dependencies. Fixes #7397 Relevant to firebase/firebase-android-sdk#6232 and androidx/media#1700 RELNOTES=Added `j2objc-annotations` to the Gradle runtime classpath to avoid [an Android Gradle Plugin error](#7397). PiperOrigin-RevId: 677842769
I released Guava 33.3.1, which contains what I believe should be a fix. Is expect that users could eliminate the error by declaring an explicit dependency on that version, and AndroidX can upgrade to that version so that anyone who then upgrades the media library will likewise no longer see the problem. Let me know if any of that doesn't work as expected. Sorry again for the problem. |
@tonihei can you please bump and confirm? |
@ShivamGoyal1899 You should be able to upgrade and confirm this in your app by adding Independent of that, we'll also update our dependency to include this fix automatically from the next Media3 release. |
We upgraded our dependency too, so the fix should be automatically included from the next Media3 release. |
This bugfix release contains a fix for Issue: #1700. PiperOrigin-RevId: 679493263
@tonihei can you possibly hotfix this onto the existing release? |
@ShivamGoyal1899 See my comment above, you should be able to easily fix this yourself in your set up until the next version of Media3 is released. |
Version
Media3 1.4.1
More version details
No response
Devices that reproduce the issue
Build issue, not related to device.
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Not tested
Reproduction steps
Add dependency and won't buiild.
Expected result
Compile successfully.
Actual result
Build fails w/ below log.
Media
Not applicable
Bug Report
adb bugreport
to [email protected] after filing this issue.The text was updated successfully, but these errors were encountered: