Fixes early transiton to Player.STATE_ENDED with MPD transition dy…
#1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…amic to static This checkin fixes Issue androidx#1441 where the player transitons to `Player.STATE_ENDED` once the buffer runs out on a DASH start-over playlist that has transitioned from dynamic to static. The fix detects the DASH Period has changed offset to the window, which occurs when the origin vendor follows the DASH-IF recommendations in *Section 4.6.4. Transition Phase between Live and On-Demand* , summerized as: - adds the attribute `MPD@mediaPresentationDuration` - removes the attribute `MPD@minimumUpdatePeriod` - `Period@start` is removed (if it was present) - `Period@duration` is added (in case more than 1 period is present) - `Adaptationset .SegmentTemplate@presentationTimeOffset` is set to earliest presentation time of a segment in the Adaptationset The MPD change does not affect the render position or the segment timeline at all, however the cleanest way to implement this was to report a `PositionUpdateForPlaylistChange` which triggers a seek and flushes the current buffered content.
stevemayhew
force-pushed
the
p-fix-socu-bug-1411
branch
from
a9f57d4
to
e1f9c22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…namic to static
This checkin fixes Issue #1441 where the player transitons to
Player.STATE_ENDEDonce the buffer runs out on a DASH start-over playlist that has transitioned from dynamic to static.The fix detects the DASH Period has changed offset to the window, which occurs when the origin vendor follows the DASH-IF recommendations in Section 4.6.4. Transition Phase between Live and On-Demand , summerized as:
MPD@mediaPresentationDurationMPD@minimumUpdatePeriodPeriod@startis removed (if it was present)Period@durationis added (in case more than 1 period is present)Adaptationset .SegmentTemplate@presentationTimeOffsetis set to earliest presentation time of a segment in the AdaptationsetThe MPD change does not affect the render position or the segment timeline at all, however the cleanest way to implement this was to report a
PositionUpdateForPlaylistChangewhich triggers a seek and flushes the current buffered content.