Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translating to windows path from the root of a mounted drive does not work #80

Closed
carlolars opened this issue Jul 10, 2019 · 2 comments
Closed

Translating to windows path from the root of a mounted drive does not work #80

carlolars opened this issue Jul 10, 2019 · 2 comments

Comments

@carlolars
Copy link
Contributor

translate_path_to_win() can not translate from the root of a mounted drive, for example the path /mnt/d does not translate to d:.
@carlolars
Copy link
Contributor Author

carlolars commented Jul 11, 2019 •
edited
Loading

translate_path_to_win() can not translate from the root of a mounted drive, for example the path /mnt/d does not translate to d:.

It should actually translate to d:/ for VSCode's git to work.

@carlolars carlolars mentioned this issue Jul 11, 2019
Merged
andy-5 pushed a commit that referenced this issue Jul 17, 2019
@carlolars @andy-5
Fixed translate_path_to_win() to work for the root of a drive. #80
0e4256d 
For example /mnt/d => d:/
@andy-5
Copy link
Owner

andy-5 commented Jul 17, 2019

Good catch, and thanks for your patch, which I just merged.

@andy-5 andy-5 closed this as completed Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andy-5 @carlolars