Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Scala 3 build for core module #226

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Nov 30, 2021

No description provided.

@xuwei-k xuwei-k mentioned this pull request Nov 30, 2021
@andyglow
Copy link
Owner

Hello, @xuwei-k , thank you for the contribution..
May I ask what this change is for?
If this is a part if a bigger intention, could you show the whole plan?

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Dec 2, 2021

May I ask what this change is for?

These changes necessary for compile with Scala 3.
Please try sbt '++ 3.1.0!' core/test. I don't know how to add Scala 3 CI settings to .drone.yml sorry.

If this is a part if a bigger intention, could you show the whole plan?

I have no plans yet another modules.(macro migration is hard... 😢 )

@andyglow
Copy link
Owner

andyglow commented Dec 2, 2021

right. macro is completely different
we can get to drone later once macro part is done

@andyglow andyglow merged commit 8af9e90 into andyglow:master Dec 2, 2021
@xuwei-k xuwei-k deleted the scala-3-core branch December 2, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants