Skip to content

Commit

Permalink
Merge pull request #1080 from aneoconsulting/feat/show-result-handle-…
Browse files Browse the repository at this point in the history
…same-id-between-sessions-and-tasks

feat: show result handle same id between sessions and tasks
  • Loading branch information
ngruelaneo authored Apr 25, 2024
2 parents 417c699 + a912e39 commit d867c89
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/app/results/show.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class ShowComponent extends AppShowComponent<ResultRaw, ResultsGrpcServic
},
{
id: 'task',
name: $localize`See task`,
name: $localize`See owner task`,
icon: this.getPageIcon('tasks'),
link: '/tasks'
}
Expand All @@ -82,7 +82,11 @@ export class ShowComponent extends AppShowComponent<ResultRaw, ResultsGrpcServic
if (data) {
this.data = data;
this.setLink('session', 'sessions', data.sessionId);
this.setLink('task', 'tasks', data.ownerTaskId);
if(data.sessionId === data.ownerTaskId) {
this.actionButtons = this.actionButtons.filter(element => element.id !== 'task');
} else {
this.setLink('task', 'tasks', data.ownerTaskId);
}
this.data$.next(data);
}
});
Expand Down

1 comment on commit d867c89

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines Statements Branches Functions
Coverage: 82%
82.57% (2929/3547) 65.33% (524/802) 72.53% (700/965)

JUnit

Tests Skipped Failures Errors Time
776 0 💤 0 ❌ 0 🔥 57.09s ⏱️
Files coverage (82%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files82.5765.3372.5382.87 
applications100100100100 
   index.component.html100100100100 
   index.component.ts100100100100 
applications/components92.9891.391.6696.22 
   table.component.html100100100100 
   table.component.ts92.8591.391.6696.15119, 133
applications/services87.577.7776.1988.23 
   applications-filters.service.ts79.1610062.581.8175–81
   applications-grpc.service.ts9271.4210091.6676–82
   applications-index.service.ts91.366.668090.970–74
components84.1376.8276.8784.24 
   actions-toolbar-group.component.ts100100100100 
   actions-toolbar.component.ts100100100100 
   auto-refresh-button.component.html100100100100 
   auto-refresh-button.component.ts1006010010036, 59
   auto-refresh-dialog.component.html100100100100 
   auto-refresh-dialog.component.ts100100100100 
   columns-button.component.ts100100100100 
   columns-modify-dialog.component.html100100100100 
   columns-modify-dialog.component.ts94.599089.4710050
   count-tasks-by-status.component.ts1005010010056
   icon-picker-dialog.component.html100100100100 
   icon-picker-dialog.component.ts96.295010096.1571
   manage-custom-dialog.component.html100100100100 
   manage-custom-dialog.component.ts23.8002535–96
   page-header.component.html100100100100 
   page-header.component.ts8010008033
   page-section-header.component.ts8010008031
   page-section.component.ts100100100100 
   refresh-button.component.ts100100100100 
   share-url.component.ts92.851007592.337
   show-action-area.component.html100100100100 
   show-action-area.component.ts100100100100 
   show-actions.component.html100100100100 
   show-actions.component.ts90085.7188.8853–54
   show-card-content.component.html100100100100 
   show-card-content.component.ts100100100100 
   show-card.component.html100100100100 
   show-card.component.ts90.910066.66100 
   show-page.component.html100100100100 
   show-page.component.ts100100100100 
   spinner.component.ts100100100100 
   table-actions-toolbar.component.html100100100100 
   table-actions-toolbar.component.ts100100100100 
   table-container.component.ts100100100100 
   table-dashboard-actions-toolbar.component.html100100100100 
   table-dashboard-actions-toolbar.component.ts2410002419–71
   table-index-actions-toolbar.component.html100100100100 
   table-index-actions-toolbar.component.ts26.08100026.0820–67
   view-tasks-by-status-dialog.component.html100100100100 
   view-tasks-by-status-dialog.component.ts100100100100 
   view-tasks-by-status.component.ts73.5206072.7259, 88–106
components/filters94.2187.493.5894.24 
   filters-chips.component.html100100100100 
   filters-chips.component.ts100100100100 
   filters-dialog-and.component.html100100100100 
   filters-dialog-and.component.ts100100100100 
   filters-dialog-filter-field.component.html100100100100 
   filters-dialog-filter-field.component.ts92.9487.597.2992.36104, 114, 124, 136–139, 147, 192–194, 201, 334
   filters-dialog-input.component.html100100100100 
   filters-dialog-input.component.ts8278.7871.4283.3357, 85–86, 142–151
   filters-dialog-or.component.html100100100100 
   filters-dialog-or.component.ts100100100100 
   filters-dialog.component.html100100100100 
   filters-dialog.component.ts100100100100 
   filters-toolbar.component.html100100100100 
   filters-toolbar.component.ts100100100100 
components/navigation99.1294.4495.8399.09 
   add-external-service-dialog.component.html100100100100 
   add-external-service-dialog.component.ts100100100100 
   change-language-button.component.html100100100100 
   change-language-button.component.ts97.291009096.9657
   edit-external-service-dialog.component.html100100100100 
   edit-external-service-dialog.component.ts100100100100 
   form-external-service.component.html100100100100 
   form-external-service.component.ts10066.6610010076
   manage-external-services-dialog.component.html100100100100 
   manage-external-services-dialog.component.ts100100100100 
   navigation.component.html100100100100 
   navigation.component.ts98.1893.3388.8898.14113
   theme-selector.component.html100100100100 
   theme-selector.component.ts100100100100 
components/table86.6672.4183.0586.17 
   table-actions.component.html100100100100 
   table-actions.component.ts61.53100061.5331–40
   table-cell.component.html100100100100 
   table-cell.component.ts87.9373.3390.4787.9340, 52, 105, 119, 129–133
   table-column-header.component.html100100100100 
   table-column-header.component.ts100100100100 
   table-empty-data.component.ts100100100100 
   table-inspect-object-dialog.component.html100100100100 
   table-inspect-object-dialog.component.ts41.66100041.6626–40
   table-inspect-object.component.html100100100100 
   table-inspect-object.component.ts60006031–50
   table.component.html100100100100 
   table.component.ts98.5587.510098.41135
dashboard89.0135.7193.3388.88 
   index.component.html100100100100 
   index.component.ts88.8835.7193.3388.76165–179, 192, 230
dashboard/components99.5910010099.58 
   add-line-dialog.component.html100100100100 
   add-line-dialog.component.ts100100100100 
   add-statuses-group-dialog.component.ts100100100100 
   edit-name-line-dialog.component.html100100100100 
   edit-name-line-dialog.component.ts100100100100 
   edit-status-group-dialog.component.ts100100100100 
   form-statuses-group.component.html100100100100 
   form-statuses-group.component.ts100100100100 
   manage-groups-dialog.component.html100100100100 
   manage-groups-dialog.component.ts100100100100 
   reorganize-lines-dialog.component.html100100100100 
   reorganize-lines-dialog.component.ts100100100100 
   split-lines-dialog.component.ts100100100100 
   statuses-group-card.component.html100100100100 
   statuses-group-card.component.ts97.9110010097.72138
dashboard/components/lines91.0985.7157.590.76 
   applications-line.component.html100100100100 
   applications-line.component.ts100100100100 
   partitions-line.component.html100100100100 
   partitions-line.component.ts78.94100077.7740–51
   results-line.component.html100100100100 
   results-line.component.ts77.77100076.4738–49
   sessions-line.component.html100100100100 
   sessions-line.component.ts81.81100080.9550–61
   task-by-status-line.component.html100100100100 
   task-by-status-line.component.ts98.885.719598.78205
   tasks-line.component.html100100100100 
   tasks-line.component.ts78.94100077.7740–51
dashboard/services93.0210093.7592.3 
   dashboard-index.service.ts89.2810091.668837–39
   dashboard-storage.service.ts100100100100 
healthcheck100100100100 
   index.component.html100100100100 
   index.component.ts100100100100 
healthcheck/services100100100100 
   healthcheck-grpc.service.ts100100100100 
   healthcheck-index.service.ts100100100100 
partitions/components97.369010097.22 
   table.component.html100100100100 
   table.component.ts97.299010097.1490
partitions/services25.710022.72 
   partitions-filters.service.ts250022.7213–94
   partitions-grpc.service.ts30.430027.2714–73
   partitions-index.service.ts21.730018.1811–120
pipes250018.18 
   duration.pipe.ts16.660011.767–27
   empty-cell.pipe.ts5000406–10
results/components100100100100 
   table.component.html100100100100 
   table.component.ts100100100100 
results/services300426.66 
   results-filters.service.ts25.92002414–108
   results-grpc.service.ts29.160026.0813–76
   results-index.service.ts21.730018.1810–117
   results-statuses.service.ts83.33100508017
services92.1175.5285.3292.06 
   auto-refresh.service.ts100100100100 
   default-config.service.ts10050100100193
   environment.service.ts80100507519
   filters.service.ts50037.55277–93
   grpc-build-request.service.ts64.288.3316.6664.2826, 39, 49, 59, 69
   grpc-sort-field.service.ts2500259–39
   icons.service.ts100100100100 
   navigation.service.ts10080100100116
   notification.service.ts100100100100 
   query-params.service.ts100100100100 
   share-url.service.ts100100100100 
   storage.service.ts97.9510010097.87108
   table-storage.service.ts500042.8511–31
   table-url.service.ts100100100100 
   table.service.ts100100100100 
   tasks-by-status.service.ts100100100100 
   user-grpc.service.ts100100100100 
   user.service.ts100100100100 
   utils.service.ts97.5694.1110097.43119
   versions-grpc.service.ts100100100100 
   versions.service.ts1007010010014, 25, 32
sessions/components54.8342.5535.3858.82 
   table.component.html100100100100 
   table.component.ts54.5942.5535.3858.57112–136, 143–167, 172–174, 177–179, 193–199, 213–215, 241, 298–308, 326–339, 347, 356, 364, 373–379, 387–409
sessions/services34.718.3316.6633.04 
   sessions-filters.service.ts66.66506070168–186
   sessions-grpc.service.ts20.40018.7518–169
   sessions-index.service.ts17.850014.8112–229
   sessions-statuses.service.ts45.45014.284018–38
tasks/components63.8216.6654.8367.44 
   table.component.html100100100100 
   table.component.ts63.4416.6654.8367.0536–44, 69–73, 112–118, 150–172, 185, 210–217
tasks/services59.632658.3359.22 
   tasks-filters.service.ts69.6983.336073.33207–220
   tasks-grpc.service.ts21.620019.4415–163
   tasks-index.service.ts87.09808086.66229, 295–300
   tasks-statuses.service.ts87.507585.7141
tokens100100100100 
   filters.token.ts100100100100 
types/components84.974.2880.7285.82 
   dashboard-line-table.ts10072.7210010064, 78–83
   index.ts71.9242.8566.6673.33104, 162–176, 187–227
   table.ts87.388.238088.1363, 96–98, 107, 132, 141

Please sign in to comment.