Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tasks created by filter #1241

Merged
merged 3 commits into from
Oct 31, 2024
Merged

feat: tasks created by filter #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5416222
feat/tasks created by filter
fdewas-aneo Oct 30, 2024
744b4d1
fix: tests
fdewas-aneo Oct 31, 2024
57330f7
Merge branch 'main' into feat/tasks-created-by-filter
fdewas-aneo Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/tasks/services/tasks-filters.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ describe('TasksFilterService', () => {

test('the service must return the right label with filterFor options', () => {
const mockLabelFilterOptions = service.retrieveLabel(service.filtersDefinitions[18].for, (service.filtersDefinitions[18].field as TaskFilterField));
expect(mockLabelFilterOptions).toEqual('Application Service');
expect(mockLabelFilterOptions).toEqual('Application Namespace');
});

test('the service must throw an error ', () => {
Expand Down
5 changes: 5 additions & 0 deletions src/app/tasks/services/tasks-filters.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,11 @@ export class TasksFiltersService implements FiltersServiceOptionsInterface<TaskS
field: TaskSummaryEnumField.TASK_SUMMARY_ENUM_FIELD_PAYLOAD_ID,
type: 'string'
},
{
for: 'root',
field: TaskSummaryEnumField.TASK_SUMMARY_ENUM_FIELD_CREATED_BY,
type: 'string',
},
{
for: 'options',
field: TaskOptionEnumField.TASK_OPTION_ENUM_FIELD_APPLICATION_NAME,
Expand Down
Loading