Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added specified not sortable columns to tasks table #858

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

fdewas-aneo
Copy link
Contributor

No description provided.

@fdewas-aneo fdewas-aneo self-assigned this Jan 4, 2024
@fdewas-aneo fdewas-aneo linked an issue Jan 4, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jan 4, 2024

Lines Statements Branches Functions
Coverage: 92%
93.08% (2396/2574) 78.68% (443/563) 87.58% (621/709)

JUnit

Tests Skipped Failures Errors Time
781 0 💤 0 ❌ 0 🔥 55.288s ⏱️
Files coverage (92%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files93.0878.6887.5892.92 
applications100100100100 
   index.component.ts100100100100 
applications/components96.3890.910097.53 
   table.component.ts96.3890.910097.53223, 237
applications/services97.180.9591.6696.96 
   applications-filters.service.ts100100100100 
   applications-grpc.service.ts10066.6610010068–69
   applications-index.service.ts93.18086.6692.8571–75
components96.9685.7192.0697.07 
   actions-toolbar-group.component.ts100100100100 
   actions-toolbar.component.ts100100100100 
   auto-refresh-button.component.ts1006010010041, 64
   auto-refresh-dialog.component.ts100100100100 
   columns-button.component.ts100100100100 
   columns-modify-dialog.component.ts96.8710093.33100 
   count-tasks-by-status.component.ts1005010010048
   page-header.component.ts8010008039
   page-section-header.component.ts8010008031
   page-section.component.ts100100100100 
   refresh-button.component.ts100100100100 
   share-url.component.ts92.851007592.337
   show-actions.component.ts86.36077.2786.04135–136, 206–221
   show-card-content.component.ts100100100100 
   show-card.component.ts7510007537–38
   show-page.component.ts100100100100 
   spinner.component.ts100100100100 
   table-actions-toolbar.component.ts100100100100 
   table-container.component.ts100100100100 
   view-tasks-by-status-dialog.component.ts100100100100 
   view-tasks-by-status.component.ts100100100100 
components/filters99.0891.5610099.06 
   filters-chips.component.ts100100100100 
   filters-dialog-and.component.ts100100100100 
   filters-dialog-filter-field.component.ts98.2194.1110098.18180
   filters-dialog-input.component.ts97.2283.8710097.14149
   filters-dialog-or.component.ts100100100100 
   filters-dialog.component.ts100100100100 
   filters-toolbar.component.ts100100100100 
components/navigation98.4210092.8598.37 
   add-external-service-dialog.component.ts100100100100 
   edit-external-service-dialog.component.ts100100100100 
   form-external-service.component.ts100100100100 
   manage-external-services-dialog.component.ts100100100100 
   navigation.component.ts95.3810076.9295.23232, 263, 292
   theme-selector.component.ts100100100100 
components/table58.620057.14 
   table-empty-data.component.ts100100100100 
   table-inspect-object-dialog.component.ts41.66100041.6636–50
   table-inspect-object.component.ts64.280064.2838–55
dashboard97.5371.4210097.5 
   index.component.ts97.5371.4210097.5212, 250
dashboard/components99.0998.0797.7799.07 
   add-line-dialog.component.ts100100100100 
   add-statuses-group-dialog.component.ts100100100100 
   edit-name-line-dialog.component.ts100100100100 
   edit-status-group-dialog.component.ts100100100100 
   form-name-line.component.ts95.6510083.3395.65115
   form-statuses-group.component.ts100100100100 
   line.component.ts98.885.719598.78272
   manage-groups-dialog.component.ts100100100100 
   reorganize-lines-dialog.component.ts100100100100 
   split-lines-dialog.component.ts100100100100 
   statuses-group-card.component.ts97.9110010097.72165
dashboard/services100100100100 
   dashboard-index.service.ts100100100100 
   dashboard-storage.service.ts100100100100 
directives50100050 
   no-wrap.directive.ts501000505–6
healthcheck100100100100 
   index.component.ts100100100100 
healthcheck/services100100100100 
   healthcheck-grpc.service.ts100100100100 
   healthcheck-index.service.ts100100100100 
partitions/components97.481.8110097.36 
   table.component.ts97.481.8110097.36223, 255
partitions/services15.620012.9 
   partitions-index.service.ts15.620012.99–119
pipes250018.18 
   duration.pipe.ts16.660011.767–27
   empty-cell.pipe.ts5000406–10
results/components100100100100 
   table.component.ts100100100100 
results/services30.76011.1127.02 
   results-index.service.ts18.180015.629–118
   results-statuses.service.ts100100100100 
services98.3694.3995.7898.24 
   auto-refresh.service.ts100100100100 
   default-config.service.ts10050100100193
   environment.service.ts80100507519
   filters.service.ts100100100100 
   icons.service.ts100100100100 
   navigation.service.ts10080100100116
   notification.service.ts100100100100 
   query-params.service.ts100100100100 
   share-url.service.ts100100100100 
   storage.service.ts98.0310010097.9595
   table-storage.service.ts500042.8511–31
   table-url.service.ts100100100100 
   table.service.ts100100100100 
   tasks-by-status.service.ts100100100100 
   user-grpc.service.ts100100100100 
   user.service.ts100100100100 
   utils.service.ts100100100100 
   versions-grpc.service.ts100100100100 
   versions.service.ts1007010010014, 25, 32
sessions/components100100100100 
   table.component.ts100100100100 
sessions/services5013.6328.5747.69 
   sessions-filters.service.ts95.836010095.65145
   sessions-index.service.ts13.150010.818–144
   sessions-statuses.service.ts100100100100 
tasks/components100100100100 
   table.component.ts100100100100 
tasks/services77.4553.784.2176.53 
   tasks-filters.service.ts100100100100 
   tasks-grpc.service.ts20.680017.8512–150
   tasks-index.service.ts100100100100 
   tasks-statuses.service.ts100100100100 
tokens100100100100 
   filters.token.ts100100100100 
types100100100100 
   filter-definition.ts100100100100 

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ngruelaneo ngruelaneo merged commit 05f4d4d into main Jan 4, 2024
8 checks passed
@ngruelaneo ngruelaneo deleted the specified-not-sortable-columns-table branch January 19, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when sorting count of retry
2 participants