feat: Better assembly resolution during dynamic loading #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneojgurhem
requested review from
ngruelaneo,
lemaitre-aneo,
melflitty-aneo,
dbrasseur-aneo and
ddiakiteaneo
aneojgurhem
force-pushed
the
jg/fixloading
branch
from
79a7490
to
4383f18
Compare
aneojgurhem
commented
May 24, 2023
| var assemblyName = new AssemblyName(args.Name).Name; | ||
| var directoryName = Path.GetDirectoryName(args.RequestingAssembly.Location)!; | ||
|
|
||
| logger_.LogInformation("Trying to load {Assembly} from {Directory}", |
There was a problem hiding this comment.
should be Debug
aneojgurhem
force-pushed
the
jg/fixloading
branch
from
4383f18
to
dbe85d1
Compare
aneojgurhem
force-pushed
the
jg/fixloading
branch
from
dbe85d1
to
27cae06
Compare
|
|
||
| PathDictionary[Path.GetDirectoryName(Assembly.GetCallingAssembly() | ||
| .Location)!] = true; | ||
| PathDictionary[Path.GetDirectoryName(typeof(CollocatedAssemblyResolver).Assembly.Location)!] = true; |
There was a problem hiding this comment.
Iterate over AppDomain.CurrentDomain.GetAssemblies() instead ?
|
|
||
| foreach (var kp in PathDictionary) | ||
| { | ||
| logger_.LogInformation("Trying to load {Assembly} from {Directory}", |
There was a problem hiding this comment.
To reduce number of logs written, move this log in the if : "Assembly found in Directory" and add a log for else "Assemble not found in Directory".
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.