Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cancelling session from sessions service cancel tasks and abort results from the session #789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aneojgurhem
Copy link
Contributor

@aneojgurhem aneojgurhem commented Oct 30, 2024

Motivation

Previously, cancelling a session from sessions service was only updating the session status, leaving all its submitted and running tasks in autoscaling count. This PR removes tasks of a cancelled session from the autoscaling count by cancelling of the tasks and results from the session.

Description

When calling the Cancel RPC from the session service, we also change task and results statuses in the cancelled session.

Testing

On an ArmoniK instance, this new implementation was used and confirmed to change the statuses.

Impact

  • It will reduce the computing resources consummed because the submitted tasks from a cancelled session will change status to cancelling and not count for autoscaling.
  • If previously cancelling tasks are not removed from the queue during downscaling, when a new session is submitted and upscaling occurs, cancelling tasks will be removed first from the queue storage before new tasks will be processed (at equal priority).

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

lemaitre-aneo
lemaitre-aneo previously approved these changes Oct 30, 2024
Common/src/gRPC/Services/GrpcSessionsService.cs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

2 participants