Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add make get-modules to destroy action #18

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

tschneider-aneo
Copy link
Contributor

@tschneider-aneo tschneider-aneo commented Oct 1, 2024

Motivation

The action fails since Terraform modules are not loaded. This PR aims to fix the job.

Description

This PR simply adds a make get-modules command before the make init .

Testing

This action is callable from https://github.com/aneoconsulting/ArmoniK/actions/workflows/manual-aws-destroy.yml .

Impact

The action loads the Terraform modules thus fixing the error.

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@tschneider-aneo tschneider-aneo merged commit 5050139 into main Oct 1, 2024
2 checks passed
@tschneider-aneo tschneider-aneo deleted the ts/fix-destroy branch October 1, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants