Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Rust from source instead of using Rustup #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

operutka
Copy link
Member

Fixes #3 and #7.

Please note that the standalone Rust binary (as proposed at #3) isn't being used here for bootstrapping. Instead, we let the Rust build scripts download their own bootstrapping binary. This shouldn't sacrifice safety/reproducibility of the build as the Rust build machinery does the necessary checks (see https://github.com/rust-lang/rust/blob/master/src/stage0.json).

@operutka operutka self-assigned this Aug 17, 2022
@operutka operutka linked an issue Aug 17, 2022 that may be closed by this pull request
@operutka
Copy link
Member Author

operutka commented Aug 17, 2022

@BKPepe @autobakterie I sincerely hope that this is the last piece of our puzzle :) Please, take a look at it and let me know if it's OK for you.

@BKPepe
Copy link
Contributor

BKPepe commented Aug 17, 2022

I'm afraid that I am not able to look at it for a few days as I have some deadlines, which I need to finish.

@operutka
Copy link
Member Author

I'm afraid that I am not able to look at it for a few days as I have some deadlines, which I need to finish.

No problem. Just let me know once you get to it. Thanks.

@autobakterie
Copy link
Contributor

autobakterie commented Aug 22, 2022

A quick update: The branch builds fine on my machine. I haven't tested full OS build in the build system yet.

@BKPepe
Copy link
Contributor

BKPepe commented Aug 24, 2022

This has been tested that it compiles the packages for Turris MOX, Turris Omnia and Turris 1.x. On the last mentioned device (the powerpc one), it was successfully run tested even though there were some minor issues, which does not prevent it from being included in Turris builds. Anyway, what's left is to review your changes and if build system correctly removes it, etc. I will take a look at it, very soon.

@operutka
Copy link
Member Author

Perfect. So are you OK with merging this PR and creating separate PRs for any additional issues that might pop up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants