Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Contribution Guide on README.md #438

Merged
merged 7 commits into from
Oct 20, 2021

Conversation

adnanqazii
Copy link
Contributor

@adnanqazii adnanqazii commented Oct 16, 2021

Description of the PR

I added useful commands and instructions for people contributing to docs such as which branch to pull request against and hosting/folder info.

Issues Related

#437


Please, before doing the PR make sure that you are following the intructions described in CONTRIBUTING.md and you have completed the following checklist

Checklist

  • Your PR is done against the dev branch
  • Your origin branch is updated with the latest changes from dev
  • All the tests and linters are passing (npm run test)
  • Your changes have tests

Thanks for contributing to Gaucho

@adnanqazii adnanqazii mentioned this pull request Oct 16, 2021
4 tasks
Copy link
Owner

@angrykoala angrykoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new section needs a bit more work to keep is consistent with the rest of the docs and easy for newcomers

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@adnanqazii
Copy link
Contributor Author

@angrykoala Please review my changes.

Copy link
Owner

@angrykoala angrykoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor changes to be ready

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@adnanqazii
Copy link
Contributor Author

@angrykoala please review.

@angrykoala angrykoala merged commit 57aaf70 into angrykoala:dev Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants