Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small simplification #626

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

small simplification #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions libs/native-federation-runtime/src/lib/init-federation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,13 @@ async function loadManifest(remotes: string): Promise<Record<string, string>> {
async function processRemoteInfos(
remotes: Record<string, string>
): Promise<ImportMap> {
const processRemoteInfoPromises = Object.keys(remotes).map(
async (remoteName) => {
const processRemoteInfoPromises = Object.entries(remotes).map(
async ([ name, url ]) => {
try {
const url = remotes[remoteName];
return await processRemoteInfo(url, remoteName);
return await processRemoteInfo(url, name);
} catch (e) {
console.error(
`Error loading remote entry for ${remoteName} from file ${remotes[remoteName]}`
`Error loading remote entry for ${name} from file ${url}`
);
return null;
}
Expand Down