Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nf): correct the index file path for SSR builds in the updateIndexHtml util #677

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vrady
Copy link
Contributor

@vrady vrady commented Oct 20, 2024

Angular CLI generates an index.csr.html file for SSR builds, causing the updateIndexHtml function to fail since it looks for an ‘index.html’ file. To ensure the function works correctly, a check for the SSR option needs to be added to the utility.

@vrady
Copy link
Contributor Author

vrady commented Oct 20, 2024

@rainerhahnekamp @manfredsteyer hi, I attempted to manage the CI, but it failed. The branch is forked from angular-architects:main, so there shouldn’t be any issues with hash checking.

@rainerhahnekamp
Copy link
Collaborator

@vrady just to be sure. You are having issues with our CI, right?

@vrady
Copy link
Contributor Author

vrady commented Oct 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants