Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(domain,feature): add property to specify build type #14

Conversation

pascalbe-dev
Copy link

I was having issues with a few things, when working with the repo:

  • When pulling the latest version from npm, I received code which had the publishable flag always being set to true when creating angular libs via the nrwl angular library schematic. I could, however, not find that in the current master branch of the repo. Is the repo out of sync with the npm deployment?
  • Testing the schematics locally (via e2e testing or directly via the CLI) did not work out of the box for me. Is the setup a bit broken or did I miss something? I'd be happy to help out, if there are some problems with the setup.

Currently, the buildable flag is not yet supported in the latest nx release (see this issue), so setting the type to "buildable" would create a lib without build target (which would be the same like using type "internal").

Closes #9

@manfredsteyer manfredsteyer merged commit b4e9b49 into angular-architects:master Jul 16, 2020
@manfredsteyer
Copy link
Contributor

Thanks for this. I guess, this PR solves the first issue you are mentioning anyway. Regarding the 2nd point (testing), I'll have a look.

@pascalbe-dev pascalbe-dev deleted the feature/9_allow-opt-out-of-publishable-lib branch July 19, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request > generate non-publishable libraries
2 participants