fix(eslint-plugin): [no-empty-lifecycle-method] incorrect suggestions and correct reports

[rafaelss95]

In addittion to the fix on suggestion, it now reports literal MethodDefinitions and removes interfaces within MemberExpressions.

Fixes #604.

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 1399bb9. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx run-many --target=integration-test --all --withRegistry
	nx run-many --target=test --all --parallel
	nx run-many --target=typecheck --all --parallel
	nx run-many --target=test --all --parallel
	nx run-many --target=build --all --parallel
	nx run-many --target=check-configs --all --parallel
	nx run-many --target=check-rule-docs --all --parallel
	nx run-many --target=build --all --parallel

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #606 (1399bb9) into master (5552b13) will decrease coverage by 0.01%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   85.76%   85.75%   -0.02%     
==========================================
  Files          89       89              
  Lines        2424     2443      +19     
  Branches      421      430       +9     
==========================================
+ Hits         2079     2095      +16     
  Misses        205      205              
- Partials      140      143       +3     

Impacted Files	Coverage Δ
packages/eslint-plugin/src/utils/utils.ts	86.53% <86.95%> (-0.60%)	⬇️
...slint-plugin/src/rules/no-conflicting-lifecycle.ts	100.00% <100.00%> (ø)
...lint-plugin/src/rules/no-empty-lifecycle-method.ts	95.23% <100.00%> (+1.90%)	⬆️
packages/eslint-plugin/src/utils/selectors.ts	100.00% <100.00%> (ø)

[JamesHenry]

Sorry about the conflicts from when the doc generation work went in

[rafaelss95]

I'm proposing to remove it because we can't guarantee that the import is only being used for this class, in other words it might be being used in another class(es) also in the same file and so we could probably be suggesting a code that does not compile. Does that make sense for you, @JamesHenry?

[JamesHenry]

Can we do a simple string-based check on the file contents for that?

If there is more than one occurrence of the string, we leave it (yes, this could have false positives, e.g. from comments, but still better than never removing it for the common case), if there is only one occurrence (the import) then we remove it?

WDYT?

[rafaelss95]

Indeed! I've submitted this check, PTAL!

[JamesHenry]

See my comment response and there are conflicts from one of your earlier PRs being merged