-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination styling is broken on IE9. #2552
Comments
One solution I've found is:
the ui-grid-pager-max-pages-number vertical position might not be the best but because of the line-height of the footer it's difficult to position it properly. If the line height is set to 1 then vertical-align: middle would work fine. Hope this helps |
Is this still happening? I saw a different IE pagination issue that seemed to suggest it was slightly overlaying the scrollbar, which implies this isn't happening any more. |
Hi, Not only IE9 but also for IE11. You can check http://ui-grid.info/docs/#/tutorial/214_pagination |
This is an issue that is not exclusive to IE. Seems very inconsistent and hard to reproduce. |
Interesting.. but it always happens when I try :) |
Anyone know anything more about a fix for pagination overlapping the grid? I need to support IE and I'm unsure how to fix this. |
The code changes fix the pagination controls display issues in IE10 and above
@JLLeitschuh @dalin92 @hikalkan The reason why this is happening is because the adjustment values are different in IE when compared to chrome and firefox. The adjustment is subtracted from the total height to get a final viewport height. e.ownerDocument.defaultView.getComputedStyle(e, null) The above statement is used in the getStyles function which returns a different height in IE when compared to other browsers. The reason being that the height in IE is excluding padding whereas the height in chrome and firefox is including padding. Possible fixes: Option 1: We could change the box-sizing property to content-box and let the code handle it, File: Pagination.less
File: pagination.js uiGridCtrl.grid.renderContainers.body.registerViewportAdjuster(function (adjustment) {
adjustment.height = adjustment.height - gridUtil.elementHeight($elm, "padding");
return adjustment;
}); Once we change to content-box, the padding will be ignored when the height is computed which brings all browsers on the same playing field. Once we pass option "padding" to the elementHeight function, it reduces the height by the padding (6px) which aligns the controls correctly (IE10+). PR #4616 Option 2: |
Fix for Pagination styling is broken on IE9. #2552
+1 for this issue - happens consistently for me |
+1 for this issue - happens consistently |
Same problem. Chrome is OK but Firefox not |
I use another temp fix. My needs : hidden scrollbars, adaptive height and pagination. ui-grid js conf :
css overload
|
I have issues with IE11 and FireFox (FireFox looks way worse). Is there a workaround? |
The above solution worked for me. You can also follow the below link. [http://dp1981.blogspot.com/2016/07/ui-grid-ie9-pagination-issue.html] |
Having the same issue in IE9 which the
|
Removed IE9 support. |
@mportuga When you make a release with that change. Remember that according to Semver, that's a major version breaking change and you should rev the major version number. |
@JLLeitschuh So, the reason for not making it a major version at the moment is because 5.0.0 is currently planned to be the angular 5 release. So I will unfortunately not be following Semver conventions correctly for the near future. However, I did call it out in the Changelog, if that makes it a little better. |
Fair enough. |
Pagination styling is broken on IE9. Here are the screenshots from IE9 and FF of one of the tutorial pages:
IE9:
FF:
The text was updated successfully, but these errors were encountered: