Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting $$treeLevel to undefined #5548

Closed
MartijnWelker opened this issue Jul 14, 2016 · 1 comment
Closed

Allow setting $$treeLevel to undefined #5548

MartijnWelker opened this issue Jul 14, 2016 · 1 comment

Comments

@MartijnWelker
Copy link
Contributor

MartijnWelker commented Jul 14, 2016

On line 26630 (v3.2.1) there's a check whether to copy the entity's $$treeLevel attribute:
if ( typeof(row.entity.$$treeLevel) !== 'undefined' && row.treeLevel !== row.entity.$$treeLevel ){

It would be nice if you could set the $$treeLevel to undefined to indicate that the row has become a leaf node.

@mjvdwater
Copy link

mjvdwater commented Jan 9, 2018

This is still an issue in v4.0.6. It is currently impossible to turn a header row into a non-header row by setting the $$treeLevel property of the row entity to undefined, while it is possible to turn a non-header row into a header row this way.
Would removing the undefined check solve this?

MartijnWelker added a commit to rentmanpublic/ui-grid that referenced this issue Oct 10, 2018
Allowing the $$treeLevel to be set to undefined allows you to change a header row into a non-header row

Fixes angular-ui#5548
MartijnWelker added a commit to rentmanpublic/ui-grid that referenced this issue Oct 10, 2018
Allowing the $$treeLevel to be set to undefined allows you to change a header row into a non-header row

Fixes angular-ui#5548
MartijnWelker added a commit to rentmanpublic/ui-grid that referenced this issue Oct 10, 2018
Setting the $$treeLevel to undefined allows you to change a header row into a non-header row

Fixes angular-ui#5548
MartijnWelker added a commit to rentmanpublic/ui-grid that referenced this issue Oct 10, 2018
Setting the $$treeLevel to undefined allows you to change a header row into a non-header row

Fixes angular-ui#5548
mportuga pushed a commit that referenced this issue Oct 16, 2018
Setting the $$treeLevel to undefined allows you to change a header row into a non-header row

Fixes #5548
defields923 pushed a commit to defields923/ui-grid that referenced this issue Oct 30, 2018
…#6867)

Setting the $$treeLevel to undefined allows you to change a header row into a non-header row

Fixes angular-ui#5548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants