Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSelectedRows broken when using ENTITY_BINDING with primitive entities #6704

Closed
5 tasks done
StrangelyTyped opened this issue Apr 26, 2018 · 0 comments · Fixed by #6712
Closed
5 tasks done

getSelectedRows broken when using ENTITY_BINDING with primitive entities #6704

StrangelyTyped opened this issue Apr 26, 2018 · 0 comments · Fixed by #6712
Assignees

Comments

@StrangelyTyped
Copy link
Contributor

StrangelyTyped commented Apr 26, 2018

  • This is a bug report, not a question on how to use the grid.
    Use Stack Overflow or Gitter for questions.
  • You have searched the open issues to see if this bug has been filed before. We don't want duplicate issues.
  • You have reviewed the tutorials and documentation to ensure you are using the grid correctly. ui-grid.info
  • You are using the latest version of the grid. Older versions are not patched or supported.
  • You have provided steps to recreate your bug. A plunkr is even better.

When using the grid with an array of primitives (as in the top example here: http://ui-grid.info/docs/#!/tutorial/323_more_binding) getSelectedRows no functions correctly returning no rows.
This can be seen in the following demonstration plunk: https://plnkr.co/edit/peULRxkeZy0QtYbE5rga?p=info where the selected items list is empty when any of the string items are selected, though works fine for the non-primitives.

The breaking change appears to be here: 0e83225 as primitive types such as strings cannot have properties such as $$hashkey and will not retain them if they are set.

@StrangelyTyped StrangelyTyped changed the title getSelectedRows broken when using ENTITY_BINDING with primitive options getSelectedRows broken when using ENTITY_BINDING with primitive entities Apr 26, 2018
@mportuga mportuga self-assigned this Apr 27, 2018
mportuga pushed a commit that referenced this issue Apr 29, 2018
Ensuring that the presence of $$hashKey is only needed for non-objects.

fix #6704
mportuga pushed a commit that referenced this issue Apr 29, 2018
Ensuring that the presence of $$hashKey is only needed for non-objects.

fix #6704
defields923 pushed a commit to defields923/ui-grid that referenced this issue Oct 30, 2018
Ensuring that the presence of $$hashKey is only needed for non-objects.

fix angular-ui#6704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants