fix(selection): Fix multiSelect + modifierKeysToMultiSelect #6793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
additional to what you changed, I also removed the line: $scope.row.setFocused(!$scope.row.isFocused); just bellow your changes because it gave me wrong coloring of the lines (a non-selected line was colored as selected) but I didn't include it in my issue as I thought you should decide what to do regarding this as I would guess that you added this line as a part of some functionality that I don't use and that removing line this would possibly break this functionality. |
|
I addressed that by removing the css which made a focus row have color as part of a different bug fix. Try 4.6.1 and if it is still reproducible, I might remove that line as well. |
defields923
pushed a commit
to defields923/ui-grid
that referenced
this pull request
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert part of 2485652
fix #6791