This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broaden the scope of #170
Generally it is considered safe to do the following:
By using
$timeout
you are guaranteed to already be in a digest and by passingfalse
as a third parameter$rootScope
won't trigger its own digest. The only potential issue is that this will be on another run of the event loop, but given the above code I think it should be fine.More information: https://docs.angularjs.org/error/$rootScope/inprog?p0=$digest