fix(bower.json): JS files should not be ignored · angular-ui/ui-router@ccdab19 · GitHub

Commit

fix(bower.json): JS files should not be ignored

Browse files

Loading branch information

eduardomb committed Jan 16, 2014

1 parent aa03555 commit ccdab19

bower.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -7,7 +7,6 @@ @@
       },
       "ignore": [
         "**/.*",
-        "*.js",
         "node_modules",
         "bower_components",
         "component.json",
@@ Expand Down @@

15 comments on commit `ccdab19`

ericclemmons commented on `ccdab19` Jan 20, 2014

@eduardomb Does this require a new tag @ v0.2.9? bower install --save angular-ui-router installs at #0.2.8, which resolves to: https://github.com/angular-ui/ui-router/archive/0.2.8.tar.gz

If you inspect this, you'll see that bower.json still has the line in place.

Contributor Author

eduardomb commented on `ccdab19` Jan 20, 2014

@ericclemmons, there is a release for this fix: 0.2.8-bowratic-tedium. You should try:

bower install --save angular-ui-router#0.2.8-bowratic-tedium

ericclemmons commented on `ccdab19` Jan 20, 2014

Ah, that specificity resolved it. We were @ ~0.2.7, so we were quiet surprised when 0.2.8 still had the issue, but bowratic-tedium solved it. Looking forward to ~0.2.9 so we can get back to auto-updated bug fixes!

teamon commented on `ccdab19` Jan 23, 2014

Could you please relese 0.2.8.1? This -bowratic-tedium suffix doesn't play well with other package manager systems like http://rails-assets.org

stephenplusplus commented on `ccdab19` Jan 27, 2014

ivancamilov commented on `ccdab19` Jan 27, 2014

I concur with @teamon and @ericclemmons. -bowratic-tedium is not Semver compliant.

sudodoki commented on `ccdab19` Jan 31, 2014

Having "angular-ui-router": "~0.2.0", set in my bower.json breaks my build. Rolling back to 0.2.6 for time being.

cgross commented on `ccdab19` Feb 6, 2014

Every new user following the getting started instructions and does bower install angular-ui-router still has a broken package until a new release is made.

nadeesha commented on `ccdab19` Feb 11, 2014

+1 for 0.2.8.1. What would be the rationale behind ignoring js files?

stephenplusplus commented on `ccdab19` Feb 14, 2014

@ProLoser @nateabele

Member

ProLoser commented on `ccdab19` Feb 14, 2014

I don't think 0.2.8.1 is valid semver

@nateabele your 0.2.8-whatever didn't work because according to semver it's considered lower than 0.2.8, so it should have been 0.2.9-whatever

Contributor

nateabele commented on `ccdab19` Feb 14, 2014

0.2.9 will be released this weekend. Bower people, please kindly cool your jets. 🍻

ericclemmons commented on `ccdab19` Feb 15, 2014

Thanks for the update @nateabele! <3 this project! (It made our internal application a breeze to work with :D)

kevinrenskers commented on `ccdab19` Feb 27, 2014

Any news on 0.2.9?

IlanFrumer commented on `ccdab19` Feb 28, 2014

0.2.9 is out, thanx !

http://stackoverflow.com/questions/21206503/ui-router-0-2-8-why-the-release-dir-is-empty

Please sign in to comment.