Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return promise from uiViewScroll #1702

Closed
mikef438 opened this issue Jan 22, 2015 · 2 comments · Fixed by #1703
Closed

Return promise from uiViewScroll #1702

mikef438 opened this issue Jan 22, 2015 · 2 comments · Fixed by #1703
Labels
feature
Milestone
0.2.14

Comments

@mikef438
Copy link
Contributor

I'm asking for the uiViewScroll function to return the timeout promise so that additional processing can occur once that is complete. The use case I have is with an iOS 7 bug on iPads that cause the screen to be blank until it's moved. In order to fix this I need to wait until the scroll completes and then move the screen an additional one pixel to make the content appear. For the time being I've had to use the source code from uiViewScroll and make my own function. Thanks!

Usage after issue resolved:
$uiViewScroll(element).then(function() { $window.scrollTo(0,1);});
@christopherthielen
Copy link
Contributor

Seems fine, can you make a PR according to the contributor guidelines?

@christopherthielen christopherthielen added this to the 0.2.14 milestone Jan 22, 2015
@mikef438
Copy link
Contributor Author

Sure

On Thursday, January 22, 2015, Chris Thielen [email protected]
wrote:

Seems fine, can you make a PR according to the contributor guidelines?

—
Reply to this email directly or view it on GitHub
#1702 (comment)
.

Mike

mikef438 added a commit to mikef438/ui-router that referenced this issue Jan 22, 2015
@mikef438
feat($uiViewScroll): change function to return promise
c2a9a31 
return the promise from the timeout for additional processing

Closes angular-ui#1702
@mikef438 mikef438 mentioned this issue Jan 22, 2015
Merged
christopherthielen pushed a commit that referenced this issue Jul 11, 2015
@mikef438 @christopherthielen
feat($uiViewScroll): change function to return promise
fd992fc 
return the promise from the timeout for additional processing

Closes #1702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.2.14
Development

Successfully merging a pull request may close this issue.

feat($uiViewScroll): change function to return promise mikef438/ui-router
2 participants
@christopherthielen @mikef438